-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows negative values in launch parameters #15941
Merged
zadjii-msft
merged 2 commits into
microsoft:main
from
codecruisedor:codecruisedor-new_style_to_allow_neg_launch_params
Sep 7, 2023
Merged
Allows negative values in launch parameters #15941
zadjii-msft
merged 2 commits into
microsoft:main
from
codecruisedor:codecruisedor-new_style_to_allow_neg_launch_params
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a style that allows negative values in the lunch position parameters.
microsoft-github-policy-service
bot
added
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Area-Settings UI
Anything specific to the SUI
Priority-2
A description (P2)
Product-Terminal
The new Windows Terminal.
labels
Sep 7, 2023
For some reason, the style that I added has extra spacing and is not formatted correctly. I formatted it correctly in VS. Did I miss something related to the |
If you launch PowerShell in the root directory of the repository you can run these 2 commands: Import-Module .\tools\OpenConsole.psm1 # just once is enough
Invoke-CodeFormat # formats all files in the repository - useful for PRs |
lhecker
approved these changes
Sep 7, 2023
Correct formatting of the style added
zadjii-msft
approved these changes
Sep 7, 2023
Thanks for doing this! I've marked it up for backporting to 1.18 :) |
codecruisedor
deleted the
codecruisedor-new_style_to_allow_neg_launch_params
branch
September 16, 2023 05:48
DHowett
pushed a commit
that referenced
this pull request
Sep 22, 2023
DHowett
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Settings UI
Anything specific to the SUI
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Priority-2
A description (P2)
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a style that allows negative values in the launch position parameters.
PR Checklist